search

GoogleCloudPlatform / netd

netd: GKE Networking Daemonset
Apache License 2.0
54 stars 41 forks source link

Pass CILIUM_FAST_START_NAMESPACES env var over into cilium-cni #277

Closed jingyuanliang closed 8 months ago

jingyuanliang commented 8 months ago

/assign @MrHohn /assign @pravk03 /hold

google-oss-prow[bot] commented 8 months ago

@jingyuanliang: GitHub didn't allow me to assign the following users: pravk03.

Note that only GoogleCloudPlatform members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/GoogleCloudPlatform/netd/pull/277): >/assign @MrHohn >/assign @pravk03 >/hold Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jingyuanliang commented 8 months ago

/assign @pravk03

google-oss-prow[bot] commented 8 months ago

@jingyuanliang: GitHub didn't allow me to assign the following users: pravk03.

Note that only GoogleCloudPlatform members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/GoogleCloudPlatform/netd/pull/277#issuecomment-1958576112): >/assign @pravk03 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jingyuanliang commented 8 months ago

/assign @pravk03

google-oss-prow[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingyuanliang, pravk03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/netd/blob/master/OWNERS)~~ [jingyuanliang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jingyuanliang commented 8 months ago

/hold cancel