Closed lutierigb closed 4 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: lutierigb Once this PR has been reviewed and has the lgtm label, please assign anfernee for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Can we add a comment saying $default_nic may be multi-line specifying multiple interfaces? In case we forget this and add the quotes back later.
https://github.com/GoogleCloudPlatform/netd/pull/308 for a better version.
closing in favor of https://github.com/GoogleCloudPlatform/netd/pull/308
in case there are two default routes the quotation marks will concatenate the interface names. without the quotes, each interface will be treated as a separate value in the for loop. see http://b/336186274#comment25