search

GoogleCloudPlatform / netd

netd: GKE Networking Daemonset
Apache License 2.0
54 stars 39 forks source link

fixing typo to properly expand variable with multiple values #306

Closed lutierigb closed 4 months ago

lutierigb commented 4 months ago

in case there are two default routes the quotation marks will concatenate the interface names. without the quotes, each interface will be treated as a separate value in the for loop. see http://b/336186274#comment25

google-oss-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lutierigb Once this PR has been reviewed and has the lgtm label, please assign anfernee for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/GoogleCloudPlatform/netd/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jingyuanliang commented 4 months ago

Can we add a comment saying $default_nic may be multi-line specifying multiple interfaces? In case we forget this and add the quotes back later.

jingyuanliang commented 4 months ago

https://github.com/GoogleCloudPlatform/netd/pull/308 for a better version.

lutierigb commented 4 months ago

closing in favor of https://github.com/GoogleCloudPlatform/netd/pull/308