search

GoogleCloudPlatform / netd

netd: GKE Networking Daemonset
Apache License 2.0
54 stars 39 forks source link

Handle multiple default routes correctly #308

Closed jingyuanliang closed 4 months ago

jingyuanliang commented 4 months ago

/assign @sypakine /assign @lutierigb /assign @yvetteli0314

google-oss-prow[bot] commented 4 months ago

@jingyuanliang: GitHub didn't allow me to assign the following users: lutierigb, yvetteli0314.

Note that only GoogleCloudPlatform members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/GoogleCloudPlatform/netd/pull/308): >/assign @sypakine >/assign @lutierigb >/assign @yvetteli0314 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
google-oss-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingyuanliang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/netd/blob/master/OWNERS)~~ [jingyuanliang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sypakine commented 4 months ago

/lgtm

Want to hear from @yvetteli0314 with regards to multi-network compatibility.