search

GoogleCloudPlatform / netd

netd: GKE Networking Daemonset
Apache License 2.0
54 stars 39 forks source link

Fix lint failures caused by koalaman/shellcheck@4f81dbe #313

Closed jingyuanliang closed 4 months ago

jingyuanliang commented 4 months ago

Not removing SC2317 for now in case of upstream reverts.

jingyuanliang commented 4 months ago

/assign @marqc /assign @aojea

google-oss-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingyuanliang, marqc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/netd/blob/master/OWNERS)~~ [jingyuanliang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment