GoogleCloudPlatform / node-red-contrib-google-cloud

Node-RED nodes for Google Cloud Platform
Apache License 2.0
90 stars 57 forks source link

Added iot core config-in node #100

Closed nated0g closed 3 years ago

nated0g commented 3 years ago

Hi @kolban-google.

As discussed in #99, I was looking for a way to receive config objects from IoT Core. I added a node for this (mostly it just involved using parts of other nodes already existing in this repository.)

It is fully working for me, the only issue I see is that in future the telemetry-send node and this node should share a connection to the Google MQTT bridge. Presently if there are telemetry-send and config-in nodes on the same flow configured for the same device, both nodes periodically reconnect, causing the config-in node to repeatedly receive the newest config when it re-subscribes after reconnection, about every 20 seconds or so.

I propose a shared configuration node for all IoT Core related nodes to allow for a single persistent connection to the bridge.

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

nated0g commented 3 years ago

@googlebot I signed it!

google-cla[bot] commented 3 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

nated0g commented 3 years ago

Should have made changes on dev branch on my fork. Resubmitting