search

GoogleCloudPlatform / node-red-contrib-google-cloud

Node-RED nodes for Google Cloud Platform
Apache License 2.0
90 stars 57 forks source link

Object localization doesn't work with Vizio node #107

Open lesusscrofa opened 2 years ago

lesusscrofa commented 2 years ago

Hello,

I can't get any result for object localization with the Visio node.

I think that the error is due to a typo in vision.js line 104 on the branch master features.push({type: "OBJECT_LOCALIZAITION"}); instead of features.push({type: "OBJECT_LOCALIZATION"});

Thanks for your work

kilters commented 2 years ago

I also have this issue. As can be seen in the screenshot, all other aspects work except OBJECT_LOCALIZATION. Please could someone address the typo as per the above comment. Thanks!

Object-localization-issue

bbordelon commented 1 year ago

Neil (@kolban-google), I didn't realize you wrote this implementation! Very slick, thank you! Any chance you could take a peek at this issue? It looks like a super quick fix (i.e. just a typo). :)

You still with the Google CE team? We should grab lunch at the Dallas office some time. Hope you're doing well, and thanks again!

kolban-google commented 1 year ago

Howdy folks ... sorry for the delay. The subject of this issue has always thrown me ... a "Vizio" node ... not not mine. Now I see it is Cloud Vision. As was commented two years ago ... this was a typo/trivial error. Code changed. I'm going to get the rest of the backlog of issues cleared/closed too before I release on npm/Node-RED a new release ... but we should be good.

bbordelon commented 1 year ago

Thanks Neil! I was also confused by the issue title. :)