search

GoogleCloudPlatform / node-red-contrib-google-cloud

Node-RED nodes for Google Cloud Platform
Apache License 2.0
90 stars 57 forks source link

GCS Read would fail if no filename supplied in configuration at coding level #27

Closed kolban-google closed 4 years ago

kolban-google commented 5 years ago

The GCS Read node expects a configuration property called filename. This works 99.9% of the time as it has a default value of "" when created in the editor. However, since this field is optional it would be legal to not supply a value at all and hence the property would simply not exist (as opposed to existing and being the empty string). This caused breakage in the logic. This issue asks for the resolution of that to handle the complete absence of the property.

kolban-google commented 5 years ago

Coding has been completed.

kolban-google commented 4 years ago

Delivered in 0.0.7.