GoogleCloudPlatform / node-red-contrib-google-cloud

Node-RED nodes for Google Cloud Platform
Apache License 2.0
90 stars 57 forks source link

Using `prefix` instead of `directory` in GCS-Read #31

Closed adamgoose closed 4 years ago

adamgoose commented 4 years ago

Currently, the "directory" option is used for listing files. However, since my files are timestamps, I'd like to be able to use the "prefix" option instead. They work the same way, except the "directory" option only matches folder names.

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

adamgoose commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

kolban-google commented 4 years ago

Thank you Adam ... this looks great. Again, MANY thanks for the contribution. Feel free to contact me anytime if there are other goodies that you would like to see in this project that you don't have time or interest to tinker with.

The changes are merged into the git repository and will push to npm at 0.0.8 and beyond. If you need this sooner, just ping.

Regards ... Neil