GoogleCloudPlatform / node-red-contrib-google-cloud

Node-RED nodes for Google Cloud Platform
Apache License 2.0
90 stars 57 forks source link

Specify a file name in the configuration for GCS Read #6

Closed kolban-google closed 5 years ago

kolban-google commented 5 years ago

Currently, we specify the file name that we wish to read through the GCS read node using msg.filename. This issue asks for an enhancement to be able to specify a file name in the configuration properties of the node. The semantics will become:

  1. If msg.filename is present, use that.
  2. If msg.filename is not present then use the configuration property of file name
  3. If neither msg.filename nor a configuration property for file name are present then that should be considered an error.
kolban-google commented 5 years ago

The implementation in code has been completed. This issue will remain open until next publish.