GoogleCloudPlatform / nodejs-docker

The Node.js Docker image used by Google App Engine Flexible.
https://cloud.google.com/nodejs
Apache License 2.0
405 stars 115 forks source link

Patch Flex Nodejs runtime to address critical CVE #229

Closed pmaloogoogle closed 2 years ago

jinglundong commented 2 years ago

Is https://github.com/GoogleCloudPlatform/nodejs-docker/pull/229/commits/8f70047d6e5728a656f5ed347e895e3da1f8aa2c done by hand? If so, I think there's no docs/process we can improve.

jinglundong commented 2 years ago

Is https://github.com/GoogleCloudPlatform/nodejs-docker/pull/229/commits/8f70047d6e5728a656f5ed347e895e3da1f8aa2c done by hand? If so, I think there's no docs/process we can improve.

pmaloogoogle commented 2 years ago

ed 1 hour ago

yes, done by hand. Basically, I looked at the errors on the cloud-build and looked online to see the possible solutions. Made those changes by hand.