GoogleCloudPlatform / nodejs-docs-samples

Node.js samples for Google Cloud Platform products.
https://cloud.google.com/nodejs
Apache License 2.0
2.82k stars 1.95k forks source link

feat: create_compute_hyperdisk #3795

Closed gryczj closed 2 months ago

gryczj commented 3 months ago

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

snippet-bot[bot] commented 3 months ago

Here is the summary of changes.

You are about to add 1 region tag. - [compute/disks/createComputeHyperdisk.js:20](https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/7f4b9eb63474dc95cf9ce19480ec3b6f1658cc20/compute/disks/createComputeHyperdisk.js#L20), tag `compute_hyperdisk_create`

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

gryczj commented 3 months ago

@subfuzion Could you help me with these problems? https://github.com/GoogleCloudPlatform/nodejs-docs-samples/actions/runs/10387680924/job/28761687813?pr=3795. Many tests- not really related to my changes are failing and I do not know what can cause it.

subfuzion commented 3 months ago

@subfuzion Could you help me with these problems? https://github.com/GoogleCloudPlatform/nodejs-docs-samples/actions/runs/10387680924/job/28761687813?pr=3795. Many tests- not really related to my changes are failing and I do not know what can cause it.


Link updated: https://github.com/GoogleCloudPlatform/nodejs-docs-samples/actions/runs/10469345301/job/28992163424?pr=3795

@gryczj Yes, I should be able to help you out; hang in there a bit longer, I'm clearing out the backlog and should be able to get to yours today as well.

gryczj commented 2 months ago

Looks like the source projects/debian-cloud/global/images/family/debian-10 does not exist. I changed the path to use debian-11 and that solved the problem. I can move these changes to separate PR and mark as refactor if there is a need.