GoogleCloudPlatform / nodejs-docs-samples

Node.js samples for Google Cloud Platform products.
https://cloud.google.com/nodejs
Apache License 2.0
2.82k stars 1.95k forks source link

feat: compute reservation create #3807

Closed gryczj closed 2 months ago

gryczj commented 2 months ago

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

gryczj commented 2 months ago

Hi @gryczj. Last week I helped with a few changes to try to stabilize ensuring resources didn't exist from previous failed tests and were removed after tests. I think you need to work with your team to come up with a more optimal solution for handling this cleanly and reliably. It seems that this is a problematic area (I had to insert delays with retries, but it felt like a bit of a brute force hack). Perhaps for compute instances, you really do need to separate these concerns into a more robust set up and tear down module with retries that you import that ensures this happens in a consistently reliable way before erroring. If it's this hard for us to do, then it's going to be hard for our customers as well, so let's convert this to draft mode while you take a bit of time to coordinate with your team to come up with something that showcases the proper way to handle this. Thank you!

@subfuzion Please see: https://github.com/GoogleCloudPlatform/nodejs-docs-samples/pull/3808

snippet-bot[bot] commented 2 months ago

Here is the summary of changes.

You are about to add 1 region tag. - [compute/reservations/createReservationFromProperties.js:20](https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/c8e5d6ca068f440a81d3991fc4309b66916d88ba/compute/reservations/createReservationFromProperties.js#L20), tag `compute_reservation_create`

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

gryczj commented 2 months ago

Please review https://github.com/GoogleCloudPlatform/nodejs-docs-samples/pull/3808 first

subfuzion commented 2 months ago

@gryczj I merged #3808 and then updated this branch, but that doesn't seem to have resolved the issue, unfortunately:

https://github.com/GoogleCloudPlatform/nodejs-docs-samples/actions/runs/10686130157/job/29620561886?pr=3807#step:9:268