Closed davidcavazos closed 15 hours ago
This is a solid starting place. Plenty of feedback to make this more robust, but nothing that I think should stop from moving forward. I am approving, but before we merge we should confirm how this PR will impact GHA quota for the repo.
Thanks for the review. One thing we could do is disable the existing tests to not have "duplicate" tests being run on pull request. This currently doesn't support nightlies yet, but once we do, we can delete the old test workflows entirely (at least for the ones that are passing).
I didn't mention this in my review, but I love the design of the Map()
function.
Moved tests into the source directory, updated README as well.
@gemini review
@gemini review
Description
This is an effort to speed up checks for pull requests, while at the same time simplifying the existing testing infrastructure in Node.js by using a dynamic strategy matrix.
Note: We're currently not using the
run-all
command, that's infrastructure that will eventually be used to optimize the nightly jobs.These new tests are marked as
experimental
, so they shouldn't block any pull requests from merging. Once we have all the tests working on the new infrastructure and we feel comfortable with it, we can go ahead and disable the old tests.Checklist
npm test
(see Testing)npm run lint
(see Style)GoogleCloudPlatform/nodejs-docs-samples
. Not a fork.