search

GoogleCloudPlatform / nodejs-getting-started

A tutorial for creating a complete application using Node.js on Google Cloud Platform
https://cloud.google.com/nodejs
Apache License 2.0
809 stars 381 forks source link

fix firestore session config example issue #431

Closed GeBeater closed 4 years ago

GeBeater commented 4 years ago

The Collection (kind) must be configured in the StoreOptions of the FirestoreStore and not in the settings of the Firestore.

https://github.com/googleapis/nodejs-firestore-session#using-the-client-library

GeBeater commented 4 years ago

@fhinkel Thanks for approving the PR. 🙂 It is my first PR for this project. Is there anything else I have to do to fulfill e. g. ci/kokoro: lint that the PR will be merged?

gcf-merge-on-green[bot] commented 4 years ago

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

gcf-merge-on-green[bot] commented 4 years ago

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

gcf-merge-on-green[bot] commented 4 years ago

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

gcf-merge-on-green[bot] commented 4 years ago

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

GeBeater commented 4 years ago

@fhinkel What I have to do to fullfill ci/kokoro: lint requirement?

gcf-merge-on-green[bot] commented 4 years ago

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

fhinkel commented 4 years ago

@GeBeater Sorry this is weird, there should be ~7 Ci jobs, not only the linter. I'm not sure why they disappeared and why the linter job is not starting 🤔 @sofisl Any idea how to fix that? Reopen the same PR?