search

GoogleCloudPlatform / nodejs-getting-started

A tutorial for creating a complete application using Node.js on Google Cloud Platform
https://cloud.google.com/nodejs
Apache License 2.0
809 stars 381 forks source link

build: migrate to actions and cloud build #471

Closed JustinBeckwith closed 2 years ago

JustinBeckwith commented 3 years ago

Transitions us from using Kokoro to Cloud Build for testing. Uses the setup script to create triggers. After landing this, we would submit a CL to delete the kokoro configs.

Currently blocked on nightly crons and integration with FlakyBot.

sofisl commented 3 years ago

@JustinBeckwith, should we delete the Kokoro configs? It seems like this whole repository is blocked with this change.

JustinBeckwith commented 3 years ago

@sofisl yeah I wouldn't land this until we switched up the required branches. Nothing is blocked right now on this change specifically. I just finally got tests passing here yesterday.

JustinBeckwith commented 3 years ago

Alright @sofisl @bcoe this is actually ready for a review this time :) Please pay special attention to the bash script because I don't know bash 🙃

tmatsuo commented 2 years ago

I think we decided to use github actions. Closing.