GoogleCloudPlatform / notebooks-blueprint-security

Opinionated setup for securely using AI Platform Notebooks.
https://registry.terraform.io/modules/GoogleCloudPlatform/notebooks-blueprint-security/google
Apache License 2.0
41 stars 14 forks source link

initial integration test with foundational blueprint #1

Closed erlanderlo closed 3 years ago

erlanderlo commented 3 years ago

Modifications to allow deployment both with and without the blueprint security foundation.

jasonbisson commented 3 years ago

Hardcoded file on line 216

terraform apply \ -var-file="terraform.elo.tfvars" \

jasonbisson commented 3 years ago

for the folder.tf file I would use a for_each to create the projects.

resource "google_project" "projects" for_each = toset(var.projects) name = "${each.value}" project_id = "${each.value}" folder_id = google_folder.fldr_trusted.name billing_account = var.billing_account } variable "projects" { description = "projects to deploy" type = list(string) default = [ "project1", "project2", "project3", "project4"] }

erlanderlo commented 3 years ago

the folders are created separately because they need to be explicitly defined. Although today they look like they have the same billing account, they will likely be owned by different BUs. In addition, the structural/folder creation will move out of this blueprint based on feedback.

erlanderlo commented 3 years ago

splitting this PR into smaller chunks to facilitate review. I've addressed all the comments thus far, so closing and moving reviews to other PRs