GoogleCloudPlatform / notebooks-blueprint-security

Opinionated setup for securely using AI Platform Notebooks.
https://registry.terraform.io/modules/GoogleCloudPlatform/notebooks-blueprint-security/google
Apache License 2.0
42 stars 15 forks source link

fix: support identity characters #55

Closed erlanderlo closed 3 years ago

erlanderlo commented 3 years ago

handle the various characters found in a user identity that does not work in a GCE instance name

fixes #53

erlanderlo commented 3 years ago
for_each = toset(["tes.t1@example.com", "te_st2@example.com", "hi'me@example.com"])

  + member1 = {
      + hi'me@example.com  = {
          + condition = []
          + etag      = (known after apply)
          + id        = (known after apply)
          + member    = "user:hime@examplecom"
          + project   = "nkb-bootstrap"
          + role      = "roles/notebooks.viewer"
        }
      + te_st2@example.com = {
          + condition = []
          + etag      = (known after apply)
          + id        = (known after apply)
          + member    = "user:test2@examplecom"
          + project   = "nkb-bootstrap"
          + role      = "roles/notebooks.viewer"
        }
      + tes.t1@example.com = {
          + condition = []
          + etag      = (known after apply)
          + id        = (known after apply)