Closed damemi closed 6 months ago
This fork currently just merges GCP config settings into the upstream Helm chart. When users follow our README, they will install the latest upstream Helm chart version. This could break in cases like https://github.com/GoogleCloudPlatform/opentelemetry-demo/issues/23 where the latest upstream has changed.
Instead, our docs should show steps for installing the specific version our config values support. Integration tests (https://github.com/GoogleCloudPlatform/opentelemetry-demo/issues/17) should catch these changes when we rebase on upstream.
This fork currently just merges GCP config settings into the upstream Helm chart. When users follow our README, they will install the latest upstream Helm chart version. This could break in cases like https://github.com/GoogleCloudPlatform/opentelemetry-demo/issues/23 where the latest upstream has changed.
Instead, our docs should show steps for installing the specific version our config values support. Integration tests (https://github.com/GoogleCloudPlatform/opentelemetry-demo/issues/17) should catch these changes when we rebase on upstream.