GoogleCloudPlatform / opentelemetry-operations-go

Apache License 2.0
130 stars 100 forks source link

Metrics exporter cache requests that fail with an unrecoverable error #768

Closed avilevy18 closed 10 months ago

avilevy18 commented 10 months ago

Fixes #765

When the metrics exporter fails to create a new metric descriptor any non-recoverable grpc errors will update the cache, preventing further CMD calls.

codecov[bot] commented 10 months ago

Codecov Report

Merging #768 (64af3e9) into main (0b578e8) will increase coverage by 0.33%. Report is 2 commits behind head on main. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #768      +/-   ##
==========================================
+ Coverage   69.52%   69.85%   +0.33%     
==========================================
  Files          42       42              
  Lines        4859     4863       +4     
==========================================
+ Hits         3378     3397      +19     
+ Misses       1331     1315      -16     
- Partials      150      151       +1     
Files Coverage Δ
exporter/collector/metrics.go 74.44% <100.00%> (+1.43%) :arrow_up:

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

punya commented 10 months ago

/gcbrun

dashpole commented 10 months ago

@avilevy18 I'm planning to cut a release later today. If you can add test coverage by then, then we can include it. Let me know if we can help direct you.

dashpole commented 10 months ago

/gcbrun

dashpole commented 10 months ago

you can run make fieldalignment to fix the error

dashpole commented 10 months ago

/gcbrun

dashpole commented 10 months ago

/gcbrun