GoogleCloudPlatform / opentelemetry-operations-go

Apache License 2.0
127 stars 99 forks source link

exporter/metric: Add support to export Distribution with Exemplars and Exponential Histograms. #777

Closed franciscovalentecastro closed 4 months ago

franciscovalentecastro commented 6 months ago

This PR adds the following functionality to the exporter/metric :

Details :

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 4.21053% with 91 lines in your changes are missing coverage. Please review.

Project coverage is 59.79%. Comparing base (87124ac) to head (1590aff).

Files Patch % Lines
exporter/metric/metric.go 4.21% 89 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #777 +/- ## ========================================== - Coverage 60.73% 59.79% -0.95% ========================================== Files 56 56 Lines 5649 5743 +94 ========================================== + Hits 3431 3434 +3 - Misses 2070 2159 +89 - Partials 148 150 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dashpole commented 4 months ago

The feature has been implemented in the OTel SDK: https://github.com/open-telemetry/opentelemetry-go/blob/main/sdk/metric/internal/x/README.md#exemplars

Let me know if you are interested in contributing this.

franciscovalentecastro commented 4 months ago

@dashpole Update on last changes to PR :

dashpole commented 4 months ago

Follow-up tasks required:

@franciscovalentecastro can you add the README? You are welcome to work on the other tasks as well if you have time. Otherwise, I'll make sure they get done. Just let me know which you'd like to tackle