Closed franciscovalentecastro closed 4 months ago
Attention: Patch coverage is 4.21053%
with 91 lines
in your changes are missing coverage. Please review.
Project coverage is 59.79%. Comparing base (
87124ac
) to head (1590aff
).
Files | Patch % | Lines |
---|---|---|
exporter/metric/metric.go | 4.21% | 89 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The feature has been implemented in the OTel SDK: https://github.com/open-telemetry/opentelemetry-go/blob/main/sdk/metric/internal/x/README.md#exemplars
Let me know if you are interested in contributing this.
@dashpole Update on last changes to PR :
dashboard.json
to visualize the exponential_histogram example. This may conflict/be confused with the other dashboard.json
in the above folder. Is this the correct place and/or naming ? (I imported manually to GCM and it works correctly).TODO
for the missing []attachments
to the exemplar exporting (AFAIU, this will add the span_id, etc, though i'm not very knowledgable about how to do this correctly).Follow-up tasks required:
@franciscovalentecastro can you add the README? You are welcome to work on the other tasks as well if you have time. Otherwise, I'll make sure they get done. Just let me know which you'd like to tackle
This PR adds the following functionality to the
exporter/metric
:ExponentialHistogram
.TypedValue
Distribution (eitherHistogram
andExponentialHistogram
) with exemplars.exponential_histogram
example with adashboard.json
to visualize it.Details :
Exemplar
data type and theExemplars
field to aHistogramDataPoint
.Exemplar
sampling support.