search

GoogleCloudPlatform / opentelemetry-operations-go

Apache License 2.0
127 stars 99 forks source link

Fixes #778 - Exemplars should be sorted before sending to Cloud Ops. #788

Closed jsuereth closed 6 months ago

jsuereth commented 6 months ago

Fixes #778

We discovered that using the fixed-sized reservoir does not guarantee exemplar order, but this is required in Cloud Operations for most distribution types.

cc @franciscovalentecastro

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (18da23f) 70.08% compared to head (bac16d7) 69.94%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #788 +/- ## ========================================== - Coverage 70.08% 69.94% -0.15% ========================================== Files 42 42 Lines 4874 4877 +3 ========================================== - Hits 3416 3411 -5 - Misses 1307 1315 +8 Partials 151 151 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

damemi commented 6 months ago

codecov failure is https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/issues/790