search

GoogleCloudPlatform / opentelemetry-operations-go

Apache License 2.0
130 stars 100 forks source link

Codecov flakes on datapointcache.go #790

Open damemi opened 9 months ago

damemi commented 9 months ago

exporter/collector/internal/datapointstorage/datapointcache.go regularly causes PR codecov checks to flake as an indirect change. See https://app.codecov.io/gh/GoogleCloudPlatform/opentelemetry-operations-go/pulls

It looks like it is usually an issue with unchecked for loops in the gc function at https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/blob/b9b7c0d5ffd765674bdb2fe502e5037e88195879/exporter/collector/internal/datapointstorage/datapointcache.go#L157

Creating this issue to track a fix or reference when approving flaking PRs

aabmass commented 8 months ago

Discussed in triage, it seems like the real issue is the tests are not deterministic/hermetic. Low priority but we would like to get this fixed.

punya commented 4 months ago

Reducing priority because (anecdotally) this hasn't come up much in recent runs.