Support gcp.source_location being set as other types

braydonk commented 8 months ago

By copying the logic from parsing gcp.http_request, this PR adds support to also parse gcp.source_location from types other than Bytes.

This fixes the basic case of #792 such that the collector does not panic when setting gcp.source_location as something other than bytes.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7329e68) 70.02% compared to head (992e990) 70.30%. Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #794 +/- ## ========================================== + Coverage 70.02% 70.30% +0.28% ========================================== Files 42 42 Lines 4877 4886 +9 ========================================== + Hits 3415 3435 +20 + Misses 1311 1303 -8 + Partials 151 148 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dashpole commented 8 months ago

/gcbrun

braydonk commented 8 months ago

/gcbrun

dashpole commented 8 months ago

@quentinmit i'll wait for your approval to merge

braydonk commented 8 months ago

/gcbrun

dashpole commented 8 months ago

/gcbrun

braydonk commented 8 months ago

Let's see if the e2e tests will work today :pray:

braydonk commented 8 months ago

/gcbrun

braydonk commented 8 months ago

I still don't seem to have permission to run these :(

punya commented 8 months ago

/gcbrun

quentinmit commented 8 months ago

/gcbrun

quentinmit commented 8 months ago

/gcbrun

GoogleCloudPlatform / opentelemetry-operations-go

Support gcp.source_location being set as other types #794

Codecov Report