search

GoogleCloudPlatform / opentelemetry-operations-go

Apache License 2.0
127 stars 99 forks source link

Support exemplars from integer instruments #810

Closed dashpole closed 4 months ago

dashpole commented 4 months ago

We weren't properly checking the value type of exemplars, meaning we were sending a value of 0 for all int exemplars.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.83%. Comparing base (b4f84b1) to head (6fb68c3).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #810 +/- ## ========================================== - Coverage 59.86% 59.83% -0.03% ========================================== Files 56 56 Lines 5743 5749 +6 ========================================== + Hits 3438 3440 +2 - Misses 2155 2159 +4 Partials 150 150 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ymotongpoo commented 4 months ago

Thank you for this fix. I try how this works.