Closed crossk3 closed 2 months ago
Thanks for finding this @crossk3!
@dashpole updated to use json.Marshal
:slightly_smiling_face:
/gcbrun
/gcbrun
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 62.30%. Comparing base (
4caace7
) to head (542da19
). Report is 6 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ah, you will need to run make fixtures
to regenerate the test files.
Ah, you will need to run
make fixtures
to regenerate the test files.
@dashpole done!
/gcbrun
:wave:
While working with the OpenTelemetry stack for Python as well as an OpenTelemetry Collector (Cloud Run Sidecar, per docs here), I noticed a discrepancy in behavior.
GCP Cloud Trace doesn't support Slice/Array data types for Trace Attributes, which Python's
CloudTraceSpanExporter
handles by flattening Slices to Strings. However, the golang Collector Exporter currently silently drops anySlice[T]
attribute. This results in some oddities when choosing how to send traces to GCP Cloud Trace, where any time a collector exports to GCP Cloud Trace you silently lose attributes you would otherwise receive in Cloud Trace.This PR attempts to unify this behavior, so that the same behavior is observed whether using the in-process exporter or the googlecloud Collector exporter.