search

GoogleCloudPlatform / opentelemetry-operations-go

Apache License 2.0
130 stars 100 forks source link

Deduplicate target_info and scope_info #838

Closed dashpole closed 5 months ago

dashpole commented 5 months ago

Fixes https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/issues/834

It ensures there is only one target_info for each unique combination of service.* resource attributes. This ensures that GMP metrics can always be joined with target_info on job + instance.

It ensures there is only one otel_scope_info for each scope name + version within a resource.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.29%. Comparing base (4caace7) to head (4698662). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #838 +/- ## ========================================== + Coverage 61.03% 62.29% +1.25% ========================================== Files 56 56 Lines 5903 4890 -1013 ========================================== - Hits 3603 3046 -557 + Misses 2143 1687 -456 Partials 157 157 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.