Closed bhshkh closed 4 weeks ago
Attention: Patch coverage is 37.50000%
with 10 lines
in your changes are missing coverage. Please review.
Project coverage is 62.52%. Comparing base (
4caace7
) to head (290e9f8
). Report is 19 commits behind head on main.:exclamation: Current head 290e9f8 differs from pull request most recent head 116bd2b
Please upload reports for the commit 116bd2b to get more accurate results.
Files | Patch % | Lines |
---|---|---|
exporter/metric/option.go | 0.00% | 6 Missing :warning: |
exporter/metric/metric.go | 60.00% | 3 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
cc @psx95
cc @psx95
This looks similar to the recent request we had for the Java exporter, I will take a look into this PR.
A similar change to the Java exporter was just approved and merged in https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/346. We would likely want to follow similar logic here.
Similar functionality has been added in #854.
Context: https://github.com/googleapis/google-cloud-go/pull/10046
I'm working on exporting Bigtable client metrics to Google Cloud Monitoring. I have tried using the exporter in its current form:
To resolve problem 1, solution similar to https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/346 is being included in this PR.
How to include monitored resource labels?
WithMonitoredResourceAttributes
to extract the resource labels from the metric labels and add them to monitored resource. Example usage:https://github.com/bhshkh/google-cloud-go/blob/bc1d79ae1a71a774b96ab94b875b8a29c0046501/bigtable/metric_monitoring_exporter.go#L72-L75