GoogleCloudPlatform / opentelemetry-operations-java

Apache License 2.0
73 stars 38 forks source link

upgrade google java format for jdk 17 #264

Closed SylvainJuge closed 11 months ago

SylvainJuge commented 1 year ago

When trying to build the project with JDK 17 and gradle assemble, I get the following error message:

> You are running Spotless on JVM 17. This requires google-java-format of at least 1.10.0 (you are using 1.9).

Just upgrading the google java format to the next version as instructed works.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

SylvainJuge commented 1 year ago

For the CLA I think I am covered by the Elastic corporate agreement, but I only visited the page after seeing this an issue, thus maybe the CLA check needs a refresh here.

psx95 commented 1 year ago

/gcbrun

psx95 commented 1 year ago

@SylvainJuge Thanks for the PR !

For the CLA I think I am covered by the Elastic corporate agreement, but I only visited the page after seeing this an issue, thus maybe the CLA check needs a refresh here.

I re-ran the CLA check, but it is still failing, could you verify that you have taken all the steps mentioned in the details for failed run ?

I see the commit you made is associated with 763082+SylvainJuge​@users.noreply.github.com which may not be the corporate email you used to register as an authorized contributer.

SylvainJuge commented 1 year ago

Switching to using my corporate email (and giving up commit signature + email privacy) seems to make the CLA check happy, so at least I have a temporary solution for this :tada: . Changing the CLA email internally is the long term solution, but this might take a bit of time to get it fixed.

dashpole commented 1 year ago

/gcbrun

SylvainJuge commented 1 year ago

Hi @dashpole could you run /gcbrun command again ? Thanks a lot for your patience here, I don't see any obvious reason related to my changes why those tests are failing.

dashpole commented 1 year ago

/gcbrun

psx95 commented 11 months ago

/gcbrun

psx95 commented 11 months ago

The failing cloud function chekd are passing after #270