search

GoogleCloudPlatform / opentelemetry-operations-java

Apache License 2.0
71 stars 38 forks source link

Rename GCPResource -> GCPResourceDetector #271

Closed psx95 closed 9 months ago

psx95 commented 10 months ago

This PR contains only refactoring required to accommodate the name change.

This is a breaking change for code depending on detector-resources.

This change was tested manually as well via the use of auto-exporter.

dashpole commented 10 months ago

This seems reasonable. What is the motivation for the change?

psx95 commented 10 months ago

This seems reasonable. What is the motivation for the change?

While working on #267, I noticed this name was confusing when manually using resource detectors (most of our samples were using it via auto-configuration so it went un-noticed before).

dashpole commented 10 months ago

Given https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/issues/266 might move this anyways, lets stick with the current naming for now to avoid breaking users unnecessarily.

psx95 commented 10 months ago

Given #266 might move this anyways, lets stick with the current naming for now to avoid breaking users unnecessarily.

Sounds good, but do we have a timeline on #266 ?

dashpole commented 10 months ago

we can talk about it at triage today

psx95 commented 9 months ago

This could be done as part of #266, we can avoid this breaking change in the next release.