Closed psx95 closed 9 months ago
Do we have any test/checks to ensure it continues to support java 8? Or is this enough, as long as we don't change this config?
Do we have any test/checks to ensure it continues to support java 8? Or is this enough, as long as we don't change this config?
No, not at the moment, I tested everything manually in a one-off fashion. We currently do not have any tests pertaining to specific Java version.
This was just the first step, checking to see if our build works properly. Once we refactor out the resource-detector-support library, we can add tests there.
However, based on the gradle documentation on release flag used in this config, I think it should give us better assurances than using the Java compatibility options.
Maybe @jsuereth can weigh in here
Description
This PR makes the resource detector Java 8 compatible. This is to support #266.
How the changes were tested
javap
tool to check the major version with which the classes was compiled -Output -
Indicates all classes within resource detector are Java 8 compatible.
Other artifacts are still compiled & targeted for Java 11.
Output -