search

GoogleCloudPlatform / opentelemetry-operations-java

Apache License 2.0
71 stars 38 forks source link

Use logstash-logback-encoder version that works with spring boot 2 #285

Closed aabmass closed 7 months ago

aabmass commented 7 months ago

This is a port over of https://github.com/GoogleCloudPlatform/java-docs-samples/pull/8984/ to this repo.

The breakage was actually caused by upgrading logstash-encoder to 7.4 because it does not support logback versions prior to 1.3.0. Spring Boot 2 uses an older logback version.

aabmass commented 7 months ago

I will upgrade to spring 3, gradle, add CI, etc. later on. Just want to get things in a working state

psx95 commented 7 months ago

I approved but let's switch this example to use gradle as well, not being on gradle is the reason why #243 has not been approved.