GoogleCloudPlatform / opentelemetry-operations-java

Apache License 2.0
71 stars 41 forks source link

instrumentation-quickstart example log4j2 config always sends `logging.googleapis.com/trace_sampled: true` #331

Open aabmass opened 4 months ago

aabmass commented 4 months ago

We send true even if trace was not sampled. See https://github.com/apache/logging-log4j2/discussions/2482 for context. In the meantime, sending true keeps the "View trace details" button working. Added in https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/330