search

GoogleCloudPlatform / opentelemetry-operations-java

Apache License 2.0
71 stars 41 forks source link

Delete unused logback xml from instrumentation quickstart #333

Closed aabmass closed 1 month ago

aabmass commented 4 months ago

This is no longer used since we switched the sample over to log4j2 in https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/330

The snippet that was here is not used in the docs anymore: image

snippet-bot[bot] commented 4 months ago

Here is the summary of changes.

You are about to delete 1 region tag. - [examples/instrumentation-quickstart/src/main/resources/logback.xml:19](https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/blob/d822ae8df4451a71f465ed44634e63d484d29ff9/examples/instrumentation-quickstart/src/main/resources/logback.xml#L19), tag `opentelemetry_instrumentation_logbackxml`

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

aabmass commented 4 months ago

Just waiting for the usage of the old snippet to be removed from the internal doc sources

aabmass commented 1 month ago

Just waiting for the usage of the old snippet to be removed from the internal doc sources

It doesn't seem like it's going to happen. I think we are good to move forward with this PR