search

GoogleCloudPlatform / opentelemetry-operations-java

Apache License 2.0
71 stars 41 forks source link

Fix #258 enable mapping when not gcp kubernetes #340

Closed tkmsaaaam closed 3 months ago

tkmsaaaam commented 4 months ago

Resolves #258

google-cla[bot] commented 4 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

dashpole commented 4 months ago

/gcbrun

psx95 commented 3 months ago

/gcbrun

psx95 commented 3 months ago

@tkmsaaaam it looks like one of the file has some formatting issues, can you run ./gradlew spotlessApply to confirm and commit any suggested changes ?

tkmsaaaam commented 3 months ago

@psx95 Thank you for reviewing many times. I fixed it.

psx95 commented 3 months ago

/gcbrun

tkmsaaaam commented 3 months ago

@psx95 My apologize. I fixed this issue. But I noticed it contained bug. So I fixed it. Please review it. https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/342