Fix #340 bug

[tkmsaaaam]

Fix #340 's bug.

I made bellow changes.

1. Use appropriate CLOUD_PROVIDER .

• shared/resourcemapping/src/test/java/com/google/cloud/opentelemetry/resource/ResourceTranslatorTest.java All or most of test case's CLOUD_PROVIDER are GCP. But I think it is not correct. It should map bellow.
  • When GCP_KUBERNETES_ENGINE then GCP
  • When AZURE_AKS then AZURE
  • When AWS_EKS then AWS
  • When null then no key and value. (not cloud)
• This mapping follows Go's repository. Like here. https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/683/files#diff-68a9a0e83deda8fe72338c49bcedd7da9b1633f67d40473059117d9db844529aR130-R343
• So I fixed about CLOUD_PROVIDER in most of cases.

2. Use appropriate CLOUD_PLATFORM.

• shared/resourcemapping/src/test/java/com/google/cloud/opentelemetry/resource/ResourceTranslatorTest.java All or most non-cloud test case's CLOUD_PLATFORM are AZURE_AKS. But it should be no keys and values.
  • here: https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/342/files#diff-bbe578011b0d984210caf2aa4e41a2c6020f0580d15396d6be3be7aff4819289L223-L293
• So I remove keys and values.

3. Add test cases about GCP .

• I did it. https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/342#discussion_r1597457360

4. Fix to map resource when platform == null

I have to map to k8s resources when this condition. If i did this.

2. Use appropriate CLOUD_PLATFORM.

Then I need duplicate these lines https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/342/files#diff-992354fc4c9a5bcfac13812fb9e420d0498483ae56b986f25e71d6649386de99L187-L198 . So I make mapK8sResourceOrGenericTaskOrNode to refactor it.

[tkmsaaaam]

I update description. https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/342#issue-2290726664

[tkmsaaaam]

Fix https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/340 's bug.

Use appropriate CLOUD_PROVIDER . Add test cases about GCP . Fix to map resource when platform == null Regarding use of appropriate cloud provider, I think GCP is correct, since GCP has Monitored Resource types for other cloud providers like AWS too.

If it is true. I don't need changes about below. I will fix it.

1. Use appropriate CLOUD_PROVIDER .

[psx95]

Thank you for the clarification, I will review this shortly!

[tkmsaaaam]

Thanks for reporting and fixing this bug! Could you address the last pending comment

Thanks for your review. I've done it.

[psx95]

/gcbrun

[psx95]

Fix #340 's bug. Use appropriate CLOUD_PROVIDER . Add test cases about GCP . Fix to map resource when platform == null Regarding use of appropriate cloud provider, I think GCP is correct, since GCP has Monitored Resource types for other cloud providers like AWS too.

If it is true. I don't need changes about below. I will fix it.

1. Use appropriate CLOUD_PROVIDER .

For posterity, the CLOUD_PROVIDER resource attribute is not added to the MR resource, as such its value does not affect the mapped resource. However, the more appropriate CLOUD_PROVIDER values should be specific to the CLOUD_PLATFORM as indicated by the tests in this PR.