search

GoogleCloudPlatform / opentelemetry-operations-java

Apache License 2.0
71 stars 41 forks source link

Make the trace flags optional when parsing x-cloud-trace-context #350

Closed sawadakaku closed 3 months ago

sawadakaku commented 3 months ago

Hello guys,

I've observed that Cloud load balancing sends requests with x-cloud-trace-context that lack o=<sampled> to the backend service. This is causing the propagator not properly to propagate the trace context. I addressed this issue by making the trace flag optional.

Could someone look over this?

Ref: https://github.com/GoogleCloudPlatform/opentelemetry-operations-python/issues/167

psx95 commented 3 months ago

/gcbrun

psx95 commented 3 months ago

Thanks for the PR!

psx95 commented 3 months ago

Fixes #351