GoogleCloudPlatform / opentelemetry-operations-js

This repository is home to Google Cloud Exporters (Trace and Monitoring) for OpenTelemetry Node.js Project (https://github.com/open-telemetry/opentelemetry-js)
Apache License 2.0
67 stars 63 forks source link

refactor: Use JSON files for TraceExporter client initialization #741

Closed kmimu closed 1 week ago

kmimu commented 2 months ago

This PR addresses the issue mentioned in Issue #404 by implementing the suggested Option 2

Checks:

Fixes #404

MichaelDoyle commented 2 weeks ago

@aabmass would you be able to take a look at this?

aabmass commented 2 weeks ago

/gcbrun

kmimu commented 1 week ago

@aabmass Thanks for your initial review! I’ve addressed all the comments, and I’d really appreciate it if you could take another look when you have a chance.

aabmass commented 1 week ago

/gcbrun

aabmass commented 1 week ago

/gcbrun

aabmass commented 1 week ago

PR looks good, just need to fix https://github.com/GoogleCloudPlatform/opentelemetry-operations-js/issues/755 before we merge

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.72%. Comparing base (7f1ee19) to head (212f314). Report is 39 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #741 +/- ## ======================================= Coverage 97.72% 97.72% ======================================= Files 18 18 Lines 703 704 +1 Branches 136 136 ======================================= + Hits 687 688 +1 Misses 16 16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aabmass commented 1 week ago

/gcbrun