Closed kmimu closed 1 week ago
@aabmass would you be able to take a look at this?
/gcbrun
@aabmass Thanks for your initial review! I’ve addressed all the comments, and I’d really appreciate it if you could take another look when you have a chance.
/gcbrun
/gcbrun
PR looks good, just need to fix https://github.com/GoogleCloudPlatform/opentelemetry-operations-js/issues/755 before we merge
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.72%. Comparing base (
7f1ee19
) to head (212f314
). Report is 39 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/gcbrun
This PR addresses the issue mentioned in Issue #404 by implementing the suggested Option 2
npm run compile-protos
commandChecks:
Fixes #404