Closed aabmass closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.72%. Comparing base (
7f1ee19
) to head (39b9457
). Report is 50 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Curious how you caught this. Did you get an automated alert? Or did we get lucky and you just happened to check?
When I was running the release steps, the npm pack
output shows and I realized we may have forgotten to include it in the tarball. I took a closer look and it was indeed missing.
In terms of automated check for this, we could add a smoke test that uses the real tarballs instead of npm workspaces symlinks–unfortunately npm workspaces don't respect the files
option.
This fixes the issue of https://github.com/GoogleCloudPlatform/opentelemetry-operations-js/issues/768 but I will leave it open until I make a new patch release
NPM pack now includes the
protos.json
in the tarball:Testing it
I also verified by installing this tarball and requiring the package now works: