search

GoogleCloudPlatform / opentelemetry-operations-python

OpenTelemetry Python exporters for Google Cloud Monitoring and Trace
https://google-cloud-opentelemetry.readthedocs.io/en/stable/
Apache License 2.0
64 stars 45 forks source link

Add WIP instrumentation quickstart sample #326

Closed dashpole closed 6 months ago

dashpole commented 6 months ago

This is mostly boilerplate to make future PRs smaller.

The following are taken from https://github.com/GoogleCloudPlatform/opentelemetry-operations-python/pull/309:

The following are minimally adapted from the java quickstart:

The quickstart runs and serves requests, but does not currently include any instrumentation. The logs are also not in the correct format.

I noticed we have some examples in docs/examples, and another example in /samples. Should we consolidate?

aabmass commented 6 months ago

I noticed we have some examples in docs/examples, and another example in /samples. Should we consolidate?

The docs under docs/examples are for https://google-cloud-opentelemetry.readthedocs.io/en/latest/. Let just leave it in /samples for now

dashpole commented 6 months ago

I'm going to switch to manual instrumentation

dashpole commented 6 months ago

I think this is ready for review. The app builds and runs successfully, but it does not include any instrumentation. I'll do that as follow-ups

dashpole commented 6 months ago

@aabmass any recommendation on testing this as part of CI? Should I use cloud build similar to the java quickstart?