Small fixups for resource detector code and tests

GoogleCloudPlatform / opentelemetry-operations-python

OpenTelemetry Python exporters for Google Cloud Monitoring and Trace

https://google-cloud-opentelemetry.readthedocs.io/en/stable/

Apache License 2.0

63 stars 45 forks source link

Small fixups for resource detector code and tests #345

Closed aabmass closed 1 month ago

aabmass commented 1 month ago

Updated the tests to not leak into os.environ
Fix code to expect numeric value for instance/id metadata
Mark metadata response JSON type annotation for instance.attributes as not-total (keys are not all required)

dashpole commented 1 month ago

is instance/id usually an int? I thought it was a UID on cloud run...

aabmass commented 1 month ago

is instance/id usually an int? I thought it was a UID on cloud run...

Hmm that's a good point. On GCE it's numeric. ~Let me see if I can just treat it as an opaque string I don't remember why I changed it anymore~

I can type annotate the id key to be either str or int. I think the code is correct either way as we do str() conversion

aabmass commented 1 month ago

The "ops-python-e2e-cloud-functions-gen2 (opentelemetry-ops-e2e)" CI failure is because I enabled the checked but implementation is in a draft PR still. Merging