search

GoogleCloudPlatform / osconfig

Apache License 2.0
84 stars 100 forks source link

Updating the Architecture structure to a string field #629

Closed darthmelonder closed 2 months ago

darthmelonder commented 2 months ago

Updating Architecture field to string field to ensure backward compatibility and add a raw field separately.

The modified structure of architecture disrupts the proto and backward compatibility here. So, this pull request reverts previous changes and updates a primitive field 'RawArch' for package.RawArch

google-oss-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: darthmelonder Once this PR has been reviewed and has the lgtm label, please assign michaljankowiak for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/GoogleCloudPlatform/osconfig/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment