GoogleCloudPlatform / osconfig

Apache License 2.0
85 stars 102 forks source link

Fix for old state file on Windows #648

Closed MarcMarc closed 3 months ago

MarcMarc commented 3 months ago

/packagebuild

MahmoudOuka commented 3 months ago

I think we will need to remove this condition from loadState function because the changes that is done on OldTaskStateFile() will be useless for Windows as long as this condition exist.

Update: It's already removed. Sorry, I didn't see it!

google-oss-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MahmoudOuka, MarcMarc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/osconfig/blob/master/OWNERS)~~ [MahmoudOuka,MarcMarc] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment