search

GoogleCloudPlatform / oss-test-infra

https://oss-prow.knative.dev
Apache License 2.0
48 stars 132 forks source link

approve enabled in repos without OWNERS files #127

Open fejta opened 4 years ago

fejta commented 4 years ago

Repos with this problem:

{
 insertId: "3206wog42gdrsb"  
 jsonPayload: {
  author: "adjackura"   
  component: "hook"   
  event-GUID: "a5d1a300-ebb8-11e9-9868-406a0c1c7f7f"   
  event-type: "issue_comment"   
  file: "prow/plugins/approve/approvers/owners.go:164"   
  func: "k8s.io/test-infra/prow/plugins/approve/approvers.Owners.GetSuggestedApprovers"   
  level: "warning"   
  msg: "Couldn't find/suggest approvers for each files. Unapproved: [""]"   
  org: "GoogleCloudPlatform"   
  plugin: "approve"   
  pr: 2   
  repo: "guest-agent"   
  url: "https://github.com/GoogleCloudPlatform/guest-agent/pull/2#issuecomment-540843760"   
 }
 labels: {…}  
 logName: "projects/oss-prow/logs/hook"  
 receiveTimestamp: "2019-10-10T23:49:58.731720740Z"  
 resource: {…}  
 severity: "ERROR"  
 timestamp: "2019-10-10T23:49:53Z"  
}
chases2 commented 4 years ago

Prow is still generating these errors; likely the same root cause

{
  author: "zmarano"   
  component: "hook"   
  event-GUID: "083f4400-07f4-11ea-97bd-1896aa3af98f"   
  event-type: "pull_request"   
  file: "prow/plugins/approve/approvers/owners.go:164"   
  func: "k8s.io/test-infra/prow/plugins/approve/approvers.Owners.GetSuggestedApprovers"   
  level: "warning"   
  msg: "Couldn't find/suggest approvers for each files. Unapproved: [""]"   
  org: "GoogleCloudPlatform"   
  plugin: "approve"   
  pr: 873   
  repo: "compute-image-packages"   
  url: "https://github.com/GoogleCloudPlatform/compute-image-packages/pull/873"   
 }