search

GoogleCloudPlatform / oss-test-infra

https://oss-prow.knative.dev
Apache License 2.0
49 stars 134 forks source link

chore: Remove KFP presubmit frontend test prow config #2302

Closed DharmitD closed 4 months ago

DharmitD commented 4 months ago

As part of migration from Prow to GH Action Workflows for KFP, we have a PR proposed to migrate presubmit frontend tests to a GHA: https://github.com/kubeflow/pipelines/pull/10923

This PR removes presubmit frontend tests from the prow config in parallel.

google-oss-prow[bot] commented 4 months ago

Hi @DharmitD. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
DharmitD commented 4 months ago

@chensun could you take a look and approve please? Thanks.

google-oss-prow[bot] commented 4 months ago

@gmfrasca: changing LGTM is restricted to collaborators

In response to [this](https://github.com/GoogleCloudPlatform/oss-test-infra/pull/2302#pullrequestreview-2126630331): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
DharmitD commented 4 months ago

cc @chensun @zijianjoy @james-jwu

google-oss-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, DharmitD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[prow/prowjobs/kubeflow/OWNERS](https://github.com/GoogleCloudPlatform/oss-test-infra/blob/master/prow/prowjobs/kubeflow/OWNERS)~~ [chensun] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
google-oss-prow[bot] commented 4 months ago

@DharmitD: Updated the job-config configmap in namespace default at cluster default using the following files:

In response to [this](https://github.com/GoogleCloudPlatform/oss-test-infra/pull/2302): >As part of migration from Prow to GH Action Workflows for KFP, we have a PR proposed to migrate presubmit frontend tests to a GHA: https://github.com/kubeflow/pipelines/pull/10923 > >This PR removes presubmit frontend tests from the prow config in parallel. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.