GoogleCloudPlatform / oss-test-infra

https://oss-prow.knative.dev
Apache License 2.0
49 stars 134 forks source link

Removed kubeflow-pipeline-upgrade-test from Kubeflow Pipelines tests #2307

Closed hbelmiro closed 3 months ago

hbelmiro commented 4 months ago

Removing kubeflow-pipeline-upgrade-test due to https://github.com/kubeflow/pipelines/pull/10932.

cc @chensun

google-oss-prow[bot] commented 4 months ago

Hi @hbelmiro. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
hbelmiro commented 4 months ago

cc @chensun @zijianjoy @james-jwu

hbelmiro commented 3 months ago

@james-jwu can you help me to get this approved?

google-oss-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, hbelmiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[prow/prowjobs/kubeflow/OWNERS](https://github.com/GoogleCloudPlatform/oss-test-infra/blob/master/prow/prowjobs/kubeflow/OWNERS)~~ [chensun] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
hbelmiro commented 3 months ago

@chensun I had to rebase. Can you please take a second look and /ok-to-test?

zijianjoy commented 3 months ago

/ok-to-test

zijianjoy commented 3 months ago

/lgtm

google-oss-prow[bot] commented 3 months ago

@hbelmiro: Updated the job-config configmap in namespace default at cluster default using the following files:

In response to [this](https://github.com/GoogleCloudPlatform/oss-test-infra/pull/2307): >Removing kubeflow-pipeline-upgrade-test due to https://github.com/kubeflow/pipelines/pull/10932. > >cc @chensun Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.