GoogleCloudPlatform / oss-test-infra

https://oss-prow.knative.dev
Apache License 2.0
48 stars 132 forks source link

chore: Remove KFP presubmit SDK Upgrade test prow config #2317

Closed DharmitD closed 1 month ago

DharmitD commented 2 months ago

As part of migration from Prow to GH Action Workflows for KFP, we have a PR proposed to migrate KFP presubmit SDK Upgrade test to a GHA: https://github.com/kubeflow/pipelines/pull/10989

This PR removes presubmit SDK Upgrade test from the prow config in parallel.

google-oss-prow[bot] commented 2 months ago

Hi @DharmitD. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
DharmitD commented 2 months ago

@zijianjoy @chensun could you please approve?

DharmitD commented 1 month ago

@chensun rebased the PR, could you please LGTM again?

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, DharmitD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[prow/prowjobs/kubeflow/OWNERS](https://github.com/GoogleCloudPlatform/oss-test-infra/blob/master/prow/prowjobs/kubeflow/OWNERS)~~ [chensun] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
chensun commented 1 month ago

/lgtm

google-oss-prow[bot] commented 1 month ago

@DharmitD: Updated the job-config configmap in namespace default at cluster default using the following files:

In response to [this](https://github.com/GoogleCloudPlatform/oss-test-infra/pull/2317): >As part of migration from Prow to GH Action Workflows for KFP, we have a PR proposed to migrate KFP presubmit SDK Upgrade test to a GHA: https://github.com/kubeflow/pipelines/pull/10989 > >This PR removes presubmit SDK Upgrade test from the prow config in parallel. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.