search

GoogleCloudPlatform / oss-test-infra

https://oss-prow.knative.dev
Apache License 2.0
48 stars 132 forks source link

chore: Remove KFP presubmit library tests prow config #2322

Closed diegolovison closed 1 month ago

diegolovison commented 2 months ago

As part of migration from Prow to GH Action Workflows for KFP, we have a PR proposed to migrate KFP presubmit SDK Runtime tests to a GHA: https://github.com/kubeflow/pipelines/pull/11006

This PR removes presubmit KFP library tests from the prow config in parallel.

google-oss-prow[bot] commented 2 months ago

Hi @diegolovison. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
hbelmiro commented 1 month ago

@chensun you approved https://github.com/kubeflow/pipelines/pull/11006. Can you also approve and /ok-to-test this?

rimolive commented 1 month ago

/ok-to-test

google-oss-prow[bot] commented 1 month ago

@rimolive: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/GoogleCloudPlatform/oss-test-infra/pull/2322#issuecomment-2252451511): >/ok-to-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rimolive commented 1 month ago

/lgtm

google-oss-prow[bot] commented 1 month ago

@rimolive: changing LGTM is restricted to collaborators

In response to [this](https://github.com/GoogleCloudPlatform/oss-test-infra/pull/2322#issuecomment-2252452450): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
zijianjoy commented 1 month ago

/ok-to-test

zijianjoy commented 1 month ago

/lgtm /approve

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: diegolovison, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[prow/prowjobs/kubeflow/OWNERS](https://github.com/GoogleCloudPlatform/oss-test-infra/blob/master/prow/prowjobs/kubeflow/OWNERS)~~ [zijianjoy] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
google-oss-prow[bot] commented 1 month ago

@diegolovison: Updated the job-config configmap in namespace default at cluster default using the following files:

In response to [this](https://github.com/GoogleCloudPlatform/oss-test-infra/pull/2322): >As part of migration from Prow to GH Action Workflows for KFP, we have a PR proposed to migrate KFP presubmit SDK Runtime tests to a GHA: https://github.com/kubeflow/pipelines/pull/11006 > >This PR removes presubmit KFP library tests from the prow config in parallel. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.