GoogleCloudPlatform / oss-test-infra

https://oss-prow.knative.dev
Apache License 2.0
48 stars 132 forks source link

enable MTU workaround for dind presets #2323

Closed sdowell closed 1 month ago

sdowell commented 1 month ago

This fixes an issue where the dind container is on a host with a MTU lower than the typical default of 1500, resulting in a mismatch.

Upstream maintainers are considering making this the default behavior of the script, but for now this is a quick workaround.

See: https://github.com/kubernetes/test-infra/blob/94f76aedb29b50131fe5dc5e131adcd23f6d4f22/images/bootstrap/runner.sh#L87

sdowell commented 1 month ago

/cc @BenTheElder

google-oss-prow[bot] commented 1 month ago

@sdowell: GitHub didn't allow me to request PR reviews from the following users: BenTheElder.

Note that only GoogleCloudPlatform members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/GoogleCloudPlatform/oss-test-infra/pull/2323#issuecomment-2234363934): >/cc @BenTheElder > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
google-oss-prow[bot] commented 1 month ago

@BenTheElder: changing LGTM is restricted to collaborators

In response to [this](https://github.com/GoogleCloudPlatform/oss-test-infra/pull/2323#pullrequestreview-2184130191): >/lgtm > >TODO: consider making this the default in the script (or something more elaborate that detects MTU and reconfigures docker instead of the iptables hack) Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michelle192837, sdowell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/oss-test-infra/blob/master/OWNERS)~~ [michelle192837] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
google-oss-prow[bot] commented 1 month ago

@sdowell: Updated the config configmap in namespace default at cluster default using the following files:

In response to [this](https://github.com/GoogleCloudPlatform/oss-test-infra/pull/2323): >This fixes an issue where the dind container is on a host with a MTU lower than the typical default of 1500, resulting in a mismatch. > >Upstream maintainers are considering making this the default behavior of the script, but for now this is a quick workaround. > >See: https://github.com/kubernetes/test-infra/blob/94f76aedb29b50131fe5dc5e131adcd23f6d4f22/images/bootstrap/runner.sh#L87 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.