GoogleCloudPlatform / oss-test-infra

https://oss-prow.knative.dev
Apache License 2.0
48 stars 132 forks source link

add node label selectors to all CS jobs #2324

Closed sdowell closed 1 month ago

sdowell commented 1 month ago

This is more flexible than the strict gke node pool selector, allowing the underlying node pools to be changed without downtime and/or coordinating changes to the prow config. Also separates presubmits from periodic nodes for better isolation/security.

sdowell commented 1 month ago

/assign @nan-yu /assign @karlkfi

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nan-yu, sdowell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[prow/prowjobs/GoogleContainerTools/kpt-config-sync/OWNERS](https://github.com/GoogleCloudPlatform/oss-test-infra/blob/master/prow/prowjobs/GoogleContainerTools/kpt-config-sync/OWNERS)~~ [nan-yu,sdowell] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
google-oss-prow[bot] commented 1 month ago

@sdowell: Updated the job-config configmap in namespace default at cluster default using the following files:

In response to [this](https://github.com/GoogleCloudPlatform/oss-test-infra/pull/2324): >This is more flexible than the strict gke node pool selector, allowing the underlying node pools to be changed without downtime and/or coordinating changes to the prow config. Also separates presubmits from periodic nodes for better isolation/security. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.