search

GoogleCloudPlatform / oss-test-infra

https://oss-prow.knative.dev
Apache License 2.0
48 stars 132 forks source link

Add transfer Issue plugin to Kubeflow repos #2331

Closed andreyvelich closed 1 month ago

andreyvelich commented 1 month ago

I added cherrypicker and transfer issue plugins to the Kubeflow repos:

This should help us with Kubeflow repo migration: https://github.com/kubeflow/kubeflow/issues/7549

Also, added kubeflow/dashboard repo to the Kubeflow list.

/hold for review

/cc @rimolive @terrytangyuan @kimwnasptd @thesuperzapper @StefanoFioravanzo @zijianjoy @johnugeorge @jbottum @james-jwu

google-oss-prow[bot] commented 1 month ago

@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: terrytangyuan, johnugeorge, StefanoFioravanzo, jbottum, rimolive, kimwnasptd, thesuperzapper.

Note that only GoogleCloudPlatform members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/GoogleCloudPlatform/oss-test-infra/pull/2331): >I added cherrypicker and transfer issue plugins to the Kubeflow repos: >- https://prow.k8s.io/command-help#cherrypick >- https://prow.k8s.io/command-help#transfer_issue > >This should help us with Kubeflow repo migration: https://github.com/kubeflow/kubeflow/issues/7549 > >Also, added `kubeflow/dashboard` repo to the Kubeflow list. > >/hold for review > >/cc @rimolive @terrytangyuan @kimwnasptd @thesuperzapper @StefanoFioravanzo @zijianjoy @johnugeorge @jbottum @james-jwu Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
google-oss-prow[bot] commented 1 month ago

Hi @andreyvelich. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
google-oss-prow[bot] commented 1 month ago

@terrytangyuan: changing LGTM is restricted to collaborators

In response to [this](https://github.com/GoogleCloudPlatform/oss-test-infra/pull/2331#pullrequestreview-2202567165): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
thesuperzapper commented 1 month ago

@andreyvelich we need to ask a googler for review.

We should also set up a policy around which situations warrant a repo transfer for an issue, especially for cases where there is ambiguity.

In cases where things are very ambiguous (technical discussions covering multiple components), I think we should use kubeflow/kubeflow, rather than community or manifests.

And keep those repos for things directly related to their contents.

andreyvelich commented 1 month ago

Sure. /assign @chaodaiG @chases2 @cjwagner @fejta @michelle192837 @mpherman2

google-oss-prow[bot] commented 1 month ago

@andreyvelich: GitHub didn't allow me to assign the following users: fejta, mpherman2.

Note that only GoogleCloudPlatform members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/GoogleCloudPlatform/oss-test-infra/pull/2331#issuecomment-2256051092): >Sure. >/assign @chaodaiG @chases2 @cjwagner @fejta @michelle192837 @mpherman2 > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
andreyvelich commented 1 month ago

In cases where things are very ambiguous (technical discussions covering multiple components)

Why we can't use kubeflow/manifests for Kubeflow platform questions (cc @juliusvonkohout) or kubeflow/community for the new project adoption and questions for the community direction? We can always reconsider it in the future, if that won't work for us.

I feel that it will be really hard to triage issues under kubeflow/kubeflow for community members and our users will feel bad about it.

andreyvelich commented 1 month ago

Additionally, I added trigger plugin to the Kubeflow: https://prow.k8s.io/command-help#ok_to_test. That will allow us to add /ok-to-test label to the PRs and trigger GitHub actions with /rerun-all command. Currently, you have to have write access to add this label to the PR.

We already use this GitHub action in several repos (Pipelines, Katib, Training Operator) to re-trigger GitHub actions using PR comments: https://github.com/estroz/rerun-actions. This actions expect ok-to-test label to be present.

cc @rimolive

cjwagner commented 1 month ago

/test all /approve

andreyvelich commented 1 month ago

/retest

google-oss-prow[bot] commented 1 month ago

@andreyvelich: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/GoogleCloudPlatform/oss-test-infra/pull/2331#issuecomment-2256468284): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
cjwagner commented 1 month ago

/ok-to-test

rimolive commented 1 month ago

I'm good with the changes.

andreyvelich commented 1 month ago

@thesuperzapper Do you know if I setup the cherrypicker plugin correctly ? I just follow the same config as for Kubernetes prow: https://github.com/kubernetes/test-infra/blob/ab0aea453361484ad834f42c7cb633f5f74a3535/config/prow/plugins.yaml#L1826.

andreyvelich commented 1 month ago

@rimolive @terrytangyuan @kimwnasptd @thesuperzapper @StefanoFioravanzo @zijianjoy @johnugeorge @jbottum @james-jwu Anything you want to add before merging this PR ?

rimolive commented 1 month ago

No other things to add. Thanks @andreyvelich for working in this PR.

andreyvelich commented 1 month ago

@zijianjoy @chensun @james-jwu @chaodaiG @chases2 @cjwagner @fejta @michelle192837 @mpherman2 Please can you help us to LGTM this PR ?

andreyvelich commented 1 month ago

/hold cancel

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, cjwagner, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/oss-test-infra/blob/master/OWNERS)~~ [cjwagner] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
google-oss-prow[bot] commented 1 month ago

@andreyvelich: Updated the plugins configmap in namespace default at cluster default using the following files:

In response to [this](https://github.com/GoogleCloudPlatform/oss-test-infra/pull/2331): >I added cherrypicker and transfer issue plugins to the Kubeflow repos: >- https://prow.k8s.io/command-help#cherrypick >- https://prow.k8s.io/command-help#transfer_issue > >This should help us with Kubeflow repo migration: https://github.com/kubeflow/kubeflow/issues/7549 > >Also, added `kubeflow/dashboard` repo to the Kubeflow list. > >/hold for review > >/cc @rimolive @terrytangyuan @kimwnasptd @thesuperzapper @StefanoFioravanzo @zijianjoy @johnugeorge @jbottum @james-jwu Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.